[Temporal] Add coverage for different rounding increments #4793
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add coverage for a variety of rounding increments for Instant, PlainTime, and ZonedDateTime (PlainDateTime already has these tests). This provides coverage for a bug observed in GraalJS that rejected certain valid rounding increments.
Ms2ger
reviewed
Dec 19, 2025
|
|
||
| [1, 2, 3, 4, 6, 8, 12].forEach((roundingIncrement) => { | ||
| assert.sameValue( | ||
| t.round({ smallestUnit: "hour", roundingIncrement }) instanceof Temporal.PlainDateTime, |
Contributor
There was a problem hiding this comment.
I'm pretty sure these shouldn't be PDTs. And probably this test would benefit from using the unitsAndIncrements table as well.
Contributor
Author
There was a problem hiding this comment.
Oops, fixed in 99c46d3; also changed it to use a table.
| }), Temporal.Instant.from("1976-11-18T14:23:30.12345679Z")); | ||
|
|
||
| const unitsAndIncrements = | ||
| {"hour": [1, 2, 4, 6, 8, 12, 24], |
Contributor
There was a problem hiding this comment.
Nit: please format these consistently between files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage for a variety of rounding increments for Instant, PlainTime, and ZonedDateTime (PlainDateTime already has these tests). This provides coverage for a bug observed in GraalJS that rejected certain valid rounding increments.