-
Notifications
You must be signed in to change notification settings - Fork 48
chore: update vault card #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6d6fafc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
Update vault card information in the changeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the vault card system by dynamically determining vault availability through API data rather than hardcoded flags. The changes include skeleton UI improvements to match the current design, removal of the static soon property from vault configurations, and a shift to API-driven vault enablement based on the /predeposits/vaults endpoint response.
- Removes static
soonproperty and replaces it with dynamic API-based vault availability checks - Updates skeleton loaders to better match the actual vault card UI states
- Changes HTML elements from
<p>to<div>tags to fix hydration errors where complex content may be nested
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
apps/hub/src/app/pre-deposits/page.tsx |
Changes TVL display wrapper from <p> to <div> to prevent hydration errors |
apps/hub/src/app/_hooks/useVaultsAPY.ts |
Updates VaultsAPYMap type to allow undefined values in the APY map |
apps/hub/src/app/_hooks/useVaultSelection.ts |
Replaces soon property filtering with API-based filtering using apyMap |
apps/hub/src/app/_constants/address.ts |
Removes soon property from Vault type and vault configurations |
apps/hub/src/app/_components/vault-card.tsx |
Replaces soon checks with isDisabled based on API presence, adds loading state for deposited balance, and updates skeleton to match current UI |
.changeset/quick-pumas-scream.md |
Adds changeset entry for the vault card updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
felicio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested previews. @pajicf could you please try disabling a vault on your end the preview deployment at https://status-network-hub-git-hub-updates-status-im-web.vercel.app/pre-deposits ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Also tested on mobile device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the button text “Deposit” should remain visible while the button is in a loading state (as shown in Figma).
But in the current implementation, the button text is not visible while loading.

Since this is a minor issue and could be intended behavior after design discussion, I'm approving this PR for now
This PR updates vault card:
predeposits/vaults- request message