Skip to content

Conversation

@jkbktl
Copy link
Collaborator

@jkbktl jkbktl commented Dec 19, 2025

This PR updates vault card:

  • updates skeleton to match current UI
  • disables vault card based on API call to predeposits/vaults - request message
  • fixes hydration error

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

🦋 Changeset detected

Latest commit: 6d6fafc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
status-network-hub Ready Ready Preview, Comment Dec 21, 2025 9:13pm
5 Skipped Deployments
Project Deployment Review Updated (UTC)
status-api Ignored Ignored Preview Dec 21, 2025 9:13pm
status-components Ignored Ignored Preview Dec 21, 2025 9:13pm
status-network-website Ignored Ignored Preview Dec 21, 2025 9:13pm
status-portfolio Ignored Ignored Preview Dec 21, 2025 9:13pm
status-website Ignored Ignored Preview Dec 21, 2025 9:13pm

Update vault card information in the changeset.
@jkbktl jkbktl changed the title Update vault card chore: update vault card Dec 19, 2025
@jkbktl jkbktl self-assigned this Dec 19, 2025
@jkbktl jkbktl marked this pull request as ready for review December 21, 2025 20:46
Copilot AI review requested due to automatic review settings December 21, 2025 20:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the vault card system by dynamically determining vault availability through API data rather than hardcoded flags. The changes include skeleton UI improvements to match the current design, removal of the static soon property from vault configurations, and a shift to API-driven vault enablement based on the /predeposits/vaults endpoint response.

  • Removes static soon property and replaces it with dynamic API-based vault availability checks
  • Updates skeleton loaders to better match the actual vault card UI states
  • Changes HTML elements from <p> to <div> tags to fix hydration errors where complex content may be nested

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/hub/src/app/pre-deposits/page.tsx Changes TVL display wrapper from <p> to <div> to prevent hydration errors
apps/hub/src/app/_hooks/useVaultsAPY.ts Updates VaultsAPYMap type to allow undefined values in the APY map
apps/hub/src/app/_hooks/useVaultSelection.ts Replaces soon property filtering with API-based filtering using apyMap
apps/hub/src/app/_constants/address.ts Removes soon property from Vault type and vault configurations
apps/hub/src/app/_components/vault-card.tsx Replaces soon checks with isDisabled based on API presence, adds loading state for deposited balance, and updates skeleton to match current UI
.changeset/quick-pumas-scream.md Adds changeset entry for the vault card updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@felicio felicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested previews. @pajicf could you please try disabling a vault on your end the preview deployment at https://status-network-hub-git-hub-updates-status-im-web.vercel.app/pre-deposits ?

@github-project-automation github-project-automation bot moved this from In Progress to Waiting in Web & User Interfaces Dec 22, 2025
Copy link
Contributor

@JulesFiliot JulesFiliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
Also tested on mobile device

Copy link
Contributor

@jinhojang6 jinhojang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the button text “Deposit” should remain visible while the button is in a loading state (as shown in Figma).

Screenshot 2025-12-22 at 5 57 43 PM

Figma: https://www.figma.com/design/1XbZL2WrTG5DqJO8DovE0H/Website----status.network?node-id=4656-16002&t=7FSh7ztR5F12r4eT-0

But in the current implementation, the button text is not visible while loading.
Screenshot 2025-12-22 at 6 01 06 PM

Since this is a minor issue and could be intended behavior after design discussion, I'm approving this PR for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting

Development

Successfully merging this pull request may close these issues.

4 participants