ENH: Generalize pd.col and expressions #63439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
commented
Dec 20, 2025
| return self._func(df) | ||
|
|
||
| def _with_binary_op(self, op: str, other: Any) -> Expression: | ||
| def _with_op(self, op: str, other: Any) -> Expression: |
Member
Author
There was a problem hiding this comment.
Renamed because we now use this for __getitem__ too.
mroeschke
reviewed
Dec 22, 2025
Comment on lines
+102
to
+112
| if op == "__getitem__": | ||
| needs_parentheses = False | ||
| repr_str = f"{self!r}[{other!r}]" | ||
| else: | ||
| needs_parentheses = True | ||
| self_repr = f"{self!r}" | ||
| if self._needs_parentheses: | ||
| self_repr = f"({self_repr})" | ||
| other_repr = f"{other!r}" | ||
| if isinstance(other, Expression) and other._needs_parentheses: | ||
| other_repr = f"({other_repr})" |
Member
There was a problem hiding this comment.
Would it make sense for Expression._with_op to accept an other_repr: str argument so we don't need to do more repr manipulation here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.qcut#63287 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.Generalizes the expressions to handle:
__getitem__qcutandwhereIn addition, it removes the unnecessary wrapping with parentheses.
main: ((col('a') + 1) * (col('b') + 1))PR: (col('a') + 1) * (col('b') + 1)Adding support for additional methods throughout pandas should be straightforward.