TYP: naming and default values #1578
Open
+73
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pyright_strict |
Contributor
Author
|
/pandas_nightly |
pandas-stubs/io/json/_json.pyi
Outdated
| ) -> DataFrame: ... | ||
|
|
||
| class JsonReader(abc.Iterator, Generic[NDFrameT]): | ||
| class JsonReader(abc.Iterator[Any], Generic[NDFrameT]): |
Member
There was a problem hiding this comment.
Can you collapse abc.Iterator and from collections.abc import Mapping
pandas-stubs/io/stata.pyi
Outdated
| @@ -1,2 +1,2 @@ | |||
| from collections import abc | |||
| from collections.abc import Sequence | |||
Member
There was a problem hiding this comment.
Collapse the two imports here if you can
loicdiridollou
requested changes
Dec 23, 2025
Member
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Minor cosmetic requests but looks good otherwise!
pandas-stubs/io/parsers/readers.pyi
Outdated
| ) -> DataFrame: ... | ||
|
|
||
| class TextFileReader(abc.Iterator): | ||
| class TextFileReader(abc.Iterator[Any]): |
Member
There was a problem hiding this comment.
Same here if possible collapse abc.Iterator into from collections.abc since both are imported
…e/naming-default-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1544.
_CrossTabValues