feat!: Use Semantic Names for ActionView #1869
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test suite was quite limited and did not provide coverage for the functionality. This commit adds test coverage by exercising a test Rails app and checking the results of the generated spans. Minitest spec does not provide out of the box support for Rails. Rather than adding an additional depedency on [Minitest Rails](https://github.com/minitest/minitest-rails), I opted to use plain old `ActionController::TestCase`.
arielvalentin
force-pushed
the
use-semantic-names
branch
from
9173477 to
86a58ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
#1868
#1867