[PoC] Headless data grid exploration #20645
Conversation
|
Deploy preview: https://deploy-preview-20645--material-ui-x.netlify.app/ Bundle size report
|
| private plugins: Map<string, Plugin<any, any, any, any, any>> = new Map(); | ||
| private pluginOrder: Plugin<any, any, any, any, any>[] = []; |
There was a problem hiding this comment.
Do we need both?
We can keep the order via the register method.
It will check the dependencies and re-create the map, so when you iterate through plugins, they will be ordered correctly.
| // 1. Create registry with internal + user plugins (order maintained) | ||
| const registry = new PluginRegistry(internalPlugins, options.plugins); | ||
|
|
||
| // 2. Initialize internal plugin states FIRST |
There was a problem hiding this comment.
If we have our dependencies set correctly, we don't have to do this
Plugins that don't have any dependencies can be initialized in any order.
| sortable?: boolean; | ||
| filterable?: boolean; |
There was a problem hiding this comment.
This needs to come from plugins (they should be able to extend ColumnDef). The same goes for row metadata.
| TState, | ||
| TApi, | ||
| TParams extends Record<string, any> = any, | ||
| TRequiredApi extends Record<string, any> = {}, |
There was a problem hiding this comment.
I like the idea that the plugin can require a specific API instead of another plugin. This way, you only need to satisfy the requirement. Another plugin doesn't have to provide exactly the same API (its API can have more optional parameters, but can still be used as a dependency).
For example, I need something that provides selectRow(id), but you give me selectRow(id, propagate = true).
The problem with this is how do you figure out if your requirement is fulfilled, if it comes from another plugin?
| export { useDataGrid } from './hooks/useDataGrid'; | ||
|
|
||
| // Plugins | ||
| export { default as sortingPlugin } from './plugins/sorting'; |
There was a problem hiding this comment.
Maybe in the core, we can only re-export everything from the plugin's index, and each plugin should make sure it has the correct exports there
| setColumns(generateColumns()); | ||
| }; | ||
|
|
||
| React.useEffect(() => { |
There was a problem hiding this comment.
I use this for checking the state and methods assigned to the grid instance object.
packages/x-data-grid-headless/src/plugins/internal/columns/columnUtils.ts
Outdated
Show resolved
Hide resolved
3 participants
No description provided.