Skip to content

Conversation

@mvkaran
Copy link
Collaborator

@mvkaran mvkaran commented Oct 23, 2025

This pull request updates the deployment configuration for the Astro project, specifically adjusting the production site URL and base path for GitHub Pages deployment.

@mvkaran mvkaran marked this pull request as ready for review October 24, 2025 12:53
Copilot AI review requested due to automatic review settings October 24, 2025 12:53
@mvkaran mvkaran merged commit a401421 into main Oct 24, 2025
6 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Astro configuration to support deployment to a custom domain (https://octocanvas.io) at the root path (/) instead of the previous GitHub Pages deployment at https://githubuniverse.github.io/octocanvas.

Key Changes:

  • Updates default site URL from GitHub Pages subdomain to custom domain
  • Changes base path from /octocanvas to / for root-level deployment

site: SITE || 'https://githubuniverse.github.io',
base: BASE_URL || '/octocanvas',
site: SITE || 'https://octocanvas.io',
base: BASE_URL || '/',
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from GitHub Pages deployment (/octocanvas base path) to custom domain deployment (/ base path) creates an inconsistency with the GitHub Actions workflow.

The workflow in .github/workflows/deploy.yml sets environment variables during build:

env:
  SITE: ${{ github.event.repository.owner.html_url }}
  BASE_URL: /${{ github.event.repository.name }}

This means when deploying via GitHub Actions, BASE_URL will be set to /octocanvas (the repository name), which will override the new default value of / specified in this configuration. This could cause the application to work locally but fail when deployed via the workflow.

Recommendation: If moving to a custom domain at root path, either:

  1. Update the GitHub Actions workflow to set BASE_URL: / for custom domain deployments, or
  2. Remove the environment variables from the workflow to use the config defaults

See below for a potential fix:

import tailwind from '@astrojs/tailwind';
import preact from '@astrojs/preact';

// Load environment variables
// const { SITE, BASE_URL } = loadEnv(process.env.NODE_ENV || 'development', process.cwd(), "");

// https://astro.build/config
export default defineConfig({
  // Configure for static site generation
  output: 'static',

  // Custom domain deployment configuration
  site: 'https://octocanvas.io',
  base: '/',

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants