-
Notifications
You must be signed in to change notification settings - Fork 126
Improve rewire-pipeline error handling for disabled repos/pipelines #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brianaj
wants to merge
13
commits into
main
Choose a base branch
from
brianaj/external-pr-1465
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GitHub migration - Added IsPipelineEnabled method to AdoApi to check if a pipeline is enabled, disabled, or paused. - Updated AdoPipelineTriggerService to skip rewiring if the repository is disabled or returns a 404. - Enhanced error handling in RewirePipelineToGitHub to return false when skipping due to disabled repositories. - Added tests for IsPipelineEnabled to verify behavior for enabled, disabled, paused, and missing queue status. - Updated tests in AdoPipelineTriggerService to ensure correct handling of disabled repositories and 404 responses. - Improved logging in RewirePipelineCommandArgs to include relevant properties while excluding MonitorTimeoutMinutes. - Set default value for MonitorTimeoutMinutes in RewirePipelineCommandArgs.
…oPipelineTriggerService
Updated release notes to reflect recent fixes and improvements in the pipeline rewiring process, including handling for disabled repositories and clearer error messages.
…ve redundant identifiers
Unit Test Results 1 files 1 suites 10m 25s ⏱️ Results for commit 25dd045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges external PR #1465 from @georgy-gorelko which improves error handling and monitoring for the
rewire-pipelinecommand.Summary
Comprehensive improvements to ADO pipeline rewiring with better error handling, especially around disabled repositories and branch policy checks. Fixes issues introduced in v1.19.0.
Key Changes
1. Fixed Branch Policy Check with Prefixed Repo Names
2. Disabled Repository Handling
3. Pipeline Disabled Check
IsPipelineEnabled()method checksqueueStatusfield4. Fixed Misleading Success Messages
RewirePipelineToGitHubto returnboolinstead ofvoid5. Monitor Timeout Display
Log()override inRewirePipelineCommandArgsexcludesMonitorTimeoutMinutes6. Caching Improvements
Test Coverage
Excellent test coverage with 11 new tests:
IsPipelineEnabledtests (4 tests)Testing
Closes #1465
cc: @georgy-gorelko