Added documentation_url field to Package model #4636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @Yashvijain1234 see comments for your consideration.
| "bug_tracking_url": null, | ||
| "code_view_url": null, | ||
| "vcs_url": null, | ||
| "documentation_url": null, |
Member
There was a problem hiding this comment.
There would a lot of other place where we have packages inthe output JSON where we need to regen, could you do a:
pytest -vvs tests/ --test-suite=validate -n 4 && SCANCODE_REGEN_TEST_FIXTURES=yes pytest -vvs tests/ --test-suite=validate --lf after configuring from your branch to regen all the tests which fail?
Signed-off-by: Yashvijain1234 <yashvijain1234@example.com>
Yashvijain1234
force-pushed
the
feature-add-doc-url
branch
from
a5490fb to
92b2269
Compare
added 2 commits
December 17, 2025 22:04
Signed-off-by: Yashvijain1234 <yashvijain1234@example.com>
Signed-off-by: Yashvijain1234 <yashvijain1234@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4092
This PR adds a new documentation_url field to the PackageData model for improved consistency and visibility.
It updates the Cargo handler to map the documentation field directly to this new attribute instead of storing it in extra_data.
All relevant model tests and Cargo fixtures have been updated to reflect this change.