Add new rule to Mulan PubL v1 License #4627
Open
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jianlang Deng <csgarytang@gmail.com>
|
Still an open issue. @alex @aslakhellesoy |
Member
|
@Tang-Kin-Long Thanks! If you see more examples of these notices that would be great! |
AyanSinhaMahapatra
approved these changes
Dec 18, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks++ @Tang-Kin-Long Looks good.
Could you also add these required phrases on the rule text so we don't detect similar texts on a partial match from this license rule?
I would also make sense to add another license reference rule with http://license.coscl.org.cn/MulanPubL-1.0 as the rule text.
add required phrases "{{Mulan PubL v1}}" on rule text
Co-authored-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
add required phrases "{{http://license.coscl.org.cn/MulanPubL-1.0}}" on rule text
Signed-off-by: Jianlang Deng <csgarytang@gmail.com>
Co-authored-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am the contributor from RecLicense project of osslab-pku, taking on the issue "Contribute updates back to ScanCode?".
I observe that in Mulan License family, the rule for detecting Mulan Public License, Version 1 (Mulan PubL v1) is not existed.
I've done some tests in local environment to show that existing rules for Mulan PSL v1, ,Mulan PSL v2, Mulan PubL v2 can adequately detect and distinguish Mulan license.
Therefore, currently I only consider to add a new rule mulanpubl-1.0_1.RULE for Mulan PubL v1, which takes the content of mulanpubl-2.0_1.RULE as reference.
Tasks
Run tests locally to check for errors.
Signed-off-by: Jianlang Deng csgarytang@gmail.com