Invalid download URL in output after version 2.5.0

[marcusball]

Summary

This action has started to return invalid URLs in the output assets of the step, like this: https://github.com/exampleOrg/exampleProject/releases/download/untagged-[random-hex-characters]/ReleaseAsset.zip instead of https://github.com/exampleOrg/exampleProject/releases/download/v1.0.0/ReleaseAsset.zip.

Hypothesis

I haven't been able to thoroughly test it, but I believe this is because of the changes in v2.5.0. If I understand correctly, now the releases are always created as a draft first, and then set to published at the end of the action. However, with the new changes the output assets with the download URL is still set before the finalization while the release is still a draft. This means the action's output returns a URL that is no longer valid since it was for the old untagged draft state.

[chenrui333]

@marcusball do you have reproducible workflow to test out?

[marcusball]

@chenrui333 Sure, here's a dummy example. You can see that the release it creates has a (correct) download URL with the version tag:

https://github.com/marcusball/action-gh-release-bug/releases/download/v1.0.1/example.zip

But the download URL retrieved from this action's output assets, which is committed into the data.json file, is an invalid "untagged" URL which 404's:

https://github.com/marcusball/action-gh-release-bug/releases/download/untagged-6e262096e814d47e0725/example.zip

[marcusball]

For good measure, I just rolled back the version of this action to v2.4.2 and ran another release action and you can see that it receives the correct download URL when the final output file is committed.