Incorrect rename refactoring in object destructuring

[dbaeumer]

🔎 Search Terms

rename refactoring object destructuring

🕗 Version & Regression Information

• This changed between versions ______ and _______
• This changed in commit or PR _______
• This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
• I was unable to test this on prior versions because _______

⏯ Playground Link

No response

💻 Code

interface IInterface {
	diagnostics: string[],
}

const inter: IInterface = { diagnostics: ["Test"] };
const { lintDiagnostics } = inter;
console.log(lintDiagnostics);

• put cursor into lintDiagnostics inside const { lintDiagnostics } = inter;
• execute rename refactoring and pick diagnostics as a new name

🙁 Actual behavior

Observe you get

interface IInterface {
	diagnostics: string[],
}

const inter: IInterface = { diagnostics: ["Test"] };
const { lintDiagnostics: diagnostics } = inter;
console.log(diagnostics);

🙂 Expected behavior

You get this:

interface IInterface {
	diagnostics: string[],
}

const inter: IInterface = { diagnostics: ["Test"] };
const { diagnostics } = inter;
console.log(diagnostics);

Additional information about the issue

No response

[dbaeumer]

cast.mp4

[MartinJohns]

That's expected to me. You're renaming the variable.

[MartinJohns]

Apparently this can be changed with a setting: #42082 (comment)

This is controlled by the setting javascript.preferences.renameShorthandProperties / typescript.preferences.renameShorthandProperties. See #29238

Used search terms: rename destructured in:title

And using your exact search issues you can immediately find this: #29238